Re: [PATCH 04/45] pathspec: add copy_pathspec

2013-06-12 Thread Junio C Hamano
Eric Sunshine writes: > On Sun, Jun 9, 2013 at 2:25 AM, Nguyễn Thái Ngọc Duy > wrote: >> The function is made to use with free_pathspec() because a simple >> struct assignment is not enough (free_pathspec wants to free "items" >> pointer). > > I had to read this about five or six times before I

Re: [PATCH 04/45] pathspec: add copy_pathspec

2013-06-09 Thread Eric Sunshine
On Sun, Jun 9, 2013 at 2:25 AM, Nguyễn Thái Ngọc Duy wrote: > The function is made to use with free_pathspec() because a simple > struct assignment is not enough (free_pathspec wants to free "items" > pointer). I had to read this about five or six times before I could parse and understand it. Per

[PATCH 04/45] pathspec: add copy_pathspec

2013-06-08 Thread Nguyễn Thái Ngọc Duy
The function is made to use with free_pathspec() because a simple struct assignment is not enough (free_pathspec wants to free "items" pointer). Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 13 +++-- pathspec.c | 8 pathspec.h | 1 + 3 files changed, 16 insertion