Re: [PATCH 04/29] log: add exhaustive tests for pattern style options & config

2017-05-13 Thread Ævar Arnfjörð Bjarmason
On Fri, May 12, 2017 at 6:48 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Add exhaustive tests for how the different grep.patternType options & >> the corresponding command-line options affect git-log. >> ... >> The patterns being passed to fixed/basic/extended/PCRE are caref

Re: [PATCH 04/29] log: add exhaustive tests for pattern style options & config

2017-05-11 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Add exhaustive tests for how the different grep.patternType options & > the corresponding command-line options affect git-log. > ... > The patterns being passed to fixed/basic/extended/PCRE are carefully > crafted to return the wrong thing if the grep engine wer

[PATCH 04/29] log: add exhaustive tests for pattern style options & config

2017-05-11 Thread Ævar Arnfjörð Bjarmason
Add exhaustive tests for how the different grep.patternType options & the corresponding command-line options affect git-log. Before this change it was possible to patch revision.c so that the --basic-regexp option was synonymous with --extended-regexp, and --perl-regexp wasn't recognized at all, a