On 06/21, Junio C Hamano wrote:
> Brandon Williams writes:
>
> > I don't think this is strictly enforced. If you look at grep.h:197 the
> > enum 'grep_source_type' has a trailing comma.
>
> OK, so we now know that at least since e1327023 ("grep: refactor the
> concept of "grep source" into an o
Brandon Williams writes:
> I don't think this is strictly enforced. If you look at grep.h:197 the
> enum 'grep_source_type' has a trailing comma.
OK, so we now know that at least since e1327023 ("grep: refactor the
concept of "grep source" into an object", 2012-02-02) we haven't
heard from anyb
On Wed, Jun 21, 2017 at 2:43 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
I looked through out code base and for enums this is
actually strictly enforced, so I guess I have to play
by the rules here as I do not want to be the first
to deviate from an upheld standard.
>>
On 06/21, Stefan Beller wrote:
> On Wed, Jun 21, 2017 at 12:36 PM, Junio C Hamano wrote:
> > Stefan Beller writes:
> >
> >> Signed-off-by: Stefan Beller
> >> ---
> >> diff.c | 22 +++---
> >> 1 file changed, 19 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/diff.c b/diff.c
Stefan Beller writes:
>>> I looked through out code base and for enums this is
>>> actually strictly enforced, so I guess I have to play
>>> by the rules here as I do not want to be the first
>>> to deviate from an upheld standard.
>>
>> You sound like you are trying to find an excuse "not to pla
On Wed, Jun 21, 2017 at 2:13 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
+enum diff_symbol {
+ DIFF_SYMBOL_SEPARATOR,
>>>
>>> Drop the last comma from enum?
>>
>> I looked through out code base and for enums this is
>> actually strictly enforced, so I guess I have to pl
Stefan Beller writes:
>>>
>>> +enum diff_symbol {
>>> + DIFF_SYMBOL_SEPARATOR,
>>
>> Drop the last comma from enum?
>
> I looked through out code base and for enums this is
> actually strictly enforced, so I guess I have to play
> by the rules here as I do not want to be the first
> to deviat
Stefan Beller writes:
> This will be painful though as the next ~20 patches
> add more symbols mostly at the end.
> , maybe I need
> to restructure that such that the last symbol stays the same
> throughout the series. Thanks for that thought.
Yes, this mostly-no-op one added in the first patch
On Wed, Jun 21, 2017 at 12:36 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> Signed-off-by: Stefan Beller
>> ---
>> diff.c | 22 +++---
>> 1 file changed, 19 insertions(+), 3 deletions(-)
>>
>> diff --git a/diff.c b/diff.c
>> index 2f9722b382..89466018e5 100644
>> --- a/
Stefan Beller writes:
> Signed-off-by: Stefan Beller
> ---
> diff.c | 22 +++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/diff.c b/diff.c
> index 2f9722b382..89466018e5 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -559,6 +559,24 @@ static void emit_line(s
Signed-off-by: Stefan Beller
---
diff.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/diff.c b/diff.c
index 2f9722b382..89466018e5 100644
--- a/diff.c
+++ b/diff.c
@@ -559,6 +559,24 @@ static void emit_line(struct diff_options *o, const char
*set, co
11 matches
Mail list logo
