Re: [PATCH 04/15] sequencer: lib'ify prepare_revs()

2016-08-26 Thread Johannes Schindelin
Hi Junio, On Thu, 25 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > To be truly useful, the sequencer should never die() but always return > > an error. > > > > Signed-off-by: Johannes Schindelin > > --- > > I am still looking at sequencer.c in 'master', but I do not thin

Re: [PATCH 04/15] sequencer: lib'ify prepare_revs()

2016-08-25 Thread Junio C Hamano
Johannes Schindelin writes: > To be truly useful, the sequencer should never die() but always return > an error. > > Signed-off-by: Johannes Schindelin > --- I am still looking at sequencer.c in 'master', but I do not think that the sole caller of this function, walk_revs_populate_todo(), is pr

[PATCH 04/15] sequencer: lib'ify prepare_revs()

2016-08-23 Thread Johannes Schindelin
To be truly useful, the sequencer should never die() but always return an error. Signed-off-by: Johannes Schindelin --- sequencer.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sequencer.c b/sequencer.c index 6ac2187..b90294f 100644 --- a/sequencer.c +++ b/sequencer