Re: [PATCH 04/14] connect: rewrite feature parsing to work on string_list

2016-05-17 Thread David Turner
On Wed, 2016-05-04 at 13:13 -0700, Junio C Hamano wrote: > Stefan Beller writes: > > > Later on when we introduce the version 2 transport protocol, the > > capabilities will not be transported in one lone string but each > > s/lone/long/, I think. > > > capability will be carried in its own pkt

Re: [PATCH 04/14] connect: rewrite feature parsing to work on string_list

2016-05-04 Thread Junio C Hamano
Stefan Beller writes: > Later on when we introduce the version 2 transport protocol, the > capabilities will not be transported in one lone string but each s/lone/long/, I think. > capability will be carried in its own pkt line. > > To reuse existing infrastructure we would either need to join

Re: [PATCH 04/14] connect: rewrite feature parsing to work on string_list

2016-05-02 Thread Stefan Beller
On Mon, May 2, 2016 at 11:18 AM, David Turner wrote: > On Fri, 2016-04-29 at 16:34 -0700, Stefan Beller wrote: >> + if (skip_prefix(item->string, "symref", &val)) { >> + if (!val) >> + continue; > > This if should never happen (skip_prefi

Re: [PATCH 04/14] connect: rewrite feature parsing to work on string_list

2016-05-02 Thread David Turner
On Fri, 2016-04-29 at 16:34 -0700, Stefan Beller wrote: > + if (skip_prefix(item->string, "symref", &val)) { > + if (!val) > + continue; This if should never happen (skip_prefix returns 0 in that case). You probably meant !*val -- but:

[PATCH 04/14] connect: rewrite feature parsing to work on string_list

2016-04-29 Thread Stefan Beller
Later on when we introduce the version 2 transport protocol, the capabilities will not be transported in one lone string but each capability will be carried in its own pkt line. To reuse existing infrastructure we would either need to join the capabilities into a single string again later or refac