Re: [PATCH 04/12] check_everything_connected: use a struct with named options

2016-07-15 Thread Jeff King
On Fri, Jul 15, 2016 at 11:13:40AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > The number of variants of check_everything_connected has > > grown over the years, so that the "real" function takes > > several possibly-zero, possibly-NULL arguments. We hid the > > complexity behind some

Re: [PATCH 04/12] check_everything_connected: use a struct with named options

2016-07-15 Thread Junio C Hamano
Jeff King writes: > The number of variants of check_everything_connected has > grown over the years, so that the "real" function takes > several possibly-zero, possibly-NULL arguments. We hid the > complexity behind some wrapper functions, but this doesn't > scale well when we want to add new opt

[PATCH 04/12] check_everything_connected: use a struct with named options

2016-07-15 Thread Jeff King
The number of variants of check_everything_connected has grown over the years, so that the "real" function takes several possibly-zero, possibly-NULL arguments. We hid the complexity behind some wrapper functions, but this doesn't scale well when we want to add new options. If we add more wrapper