Re: [PATCH 04/11] submodule.c: convert submodule_move_head new argument to object id

2018-09-06 Thread Junio C Hamano
Stefan Beller writes: > All callers use oid_to_hex to convert the desired oid to a string before > calling submodule_move_head. Defer the conversion to the > submodule_move_head as it will turn out to be useful in a bit. I would think this is a good change even without "as it will turn out..." w

[PATCH 04/11] submodule.c: convert submodule_move_head new argument to object id

2018-09-04 Thread Stefan Beller
All callers use oid_to_hex to convert the desired oid to a string before calling submodule_move_head. Defer the conversion to the submodule_move_head as it will turn out to be useful in a bit. Signed-off-by: Stefan Beller --- entry.c| 6 +++--- submodule.c| 12 ++-- submodul