Re: [PATCH 03/19] read-cache: allow to keep mmap'd memory after reading

2016-03-09 Thread David Turner
On Wed, 2016-03-09 at 15:02 -0800, Junio C Hamano wrote: > David Turner writes: > > > From: Nguyễn Thái Ngọc Duy > > > > Signed-off-by: Nguyễn Thái Ngọc Duy > > --- > > As usual in Duy's patches, this one seriously lacks "why". And also > makes the reader wonder if the memory region is ever

Re: [PATCH 03/19] read-cache: allow to keep mmap'd memory after reading

2016-03-09 Thread Junio C Hamano
David Turner writes: > From: Nguyễn Thái Ngọc Duy > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- As usual in Duy's patches, this one seriously lacks "why". And also makes the reader wonder if the memory region is ever unmapped() and if so under what condition. > diff --git a/cache.h b/cache.h

[PATCH 03/19] read-cache: allow to keep mmap'd memory after reading

2016-03-09 Thread David Turner
From: Nguyễn Thái Ngọc Duy Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 3 +++ read-cache.c | 13 - 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/cache.h b/cache.h index 7e01403..c43ef3d 100644 --- a/cache.h +++ b/cache.h @@ -333,11 +333,14 @@ struct inde