Re: [PATCH 03/14] make is_submodule_populated gently

2017-02-15 Thread Stefan Beller
On Wed, Feb 15, 2017 at 10:10 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> We need the gentle version in a later patch. As we have just one caller, >> migrate the caller. > > Ordinarily, we keep the original helper implemented as a thin > wrapper that passes NULL as retun_error_code, wh

Re: [PATCH 03/14] make is_submodule_populated gently

2017-02-15 Thread Junio C Hamano
Stefan Beller writes: > We need the gentle version in a later patch. As we have just one caller, > migrate the caller. Ordinarily, we keep the original helper implemented as a thin wrapper that passes NULL as retun_error_code, which causes it to die() on error for existing callers. But because

[PATCH 03/14] make is_submodule_populated gently

2017-02-14 Thread Stefan Beller
We need the gentle version in a later patch. As we have just one caller, migrate the caller. Signed-off-by: Stefan Beller --- builtin/grep.c | 2 +- submodule.c| 4 ++-- submodule.h| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/grep.c b/builtin/grep.c inde