Re: [PATCH 02/44] repository.c: move env-related setup code back to environment.c

2018-03-21 Thread Brandon Williams
On 03/19, Duy Nguyen wrote: > On Mon, Mar 19, 2018 at 7:07 PM, Jonathan Tan > wrote: > >> -extern void repo_set_gitdir(struct repository *repo, const char *path); > >> +struct set_gitdir_args { > >> + const char *commondir; > >> + const char *object_dir; > >> + const char *graft_file;

Re: [PATCH 02/44] repository.c: move env-related setup code back to environment.c

2018-03-19 Thread Duy Nguyen
On Mon, Mar 19, 2018 at 7:07 PM, Jonathan Tan wrote: >> -extern void repo_set_gitdir(struct repository *repo, const char *path); >> +struct set_gitdir_args { >> + const char *commondir; >> + const char *object_dir; >> + const char *graft_file; >> + const char *index_file; >> +}; >>

Re: [PATCH 02/44] repository.c: move env-related setup code back to environment.c

2018-03-19 Thread Jonathan Tan
On Sat, 3 Mar 2018 18:35:55 +0700 Nguyễn Thái Ngọc Duy wrote: > It does not make sense that generic repository code contains handling > of environment variables, which are specific for the main repository > only. Refactor repo_set_gitdir() function to take $GIT_DIR and > optionally _all_ other

[PATCH 02/44] repository.c: move env-related setup code back to environment.c

2018-03-03 Thread Nguyễn Thái Ngọc Duy
It does not make sense that generic repository code contains handling of environment variables, which are specific for the main repository only. Refactor repo_set_gitdir() function to take $GIT_DIR and optionally _all_ other customizable paths. These optional paths can be NULL and will be calculate