Re: [PATCH 02/20] safe_create_leading_directories(): set errno on SCLD_EXISTS

2016-02-18 Thread Michael Haggerty
On 02/17/2016 08:23 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> The exit path for SCLD_EXISTS wasn't setting errno, as expected by at >> least one caller. Fix the problem and document that the function sets >> errno correctly to help avoid similar regressions in the future. > >> di

Re: [PATCH 02/20] safe_create_leading_directories(): set errno on SCLD_EXISTS

2016-02-17 Thread Junio C Hamano
Michael Haggerty writes: > The exit path for SCLD_EXISTS wasn't setting errno, as expected by at > least one caller. Fix the problem and document that the function sets > errno correctly to help avoid similar regressions in the future. > diff --git a/sha1_file.c b/sha1_file.c > index 568120e..a1

[PATCH 02/20] safe_create_leading_directories(): set errno on SCLD_EXISTS

2016-02-16 Thread Michael Haggerty
The exit path for SCLD_EXISTS wasn't setting errno, as expected by at least one caller. Fix the problem and document that the function sets errno correctly to help avoid similar regressions in the future. While we're at it, document the difference between safe_create_leading_directories() and safe