Re: [PATCH 02/16] bisect: add test for the bisect algorithm

2016-02-27 Thread Matthieu Moy
Christian Couder writes: > Hi Stephan, > > On Fri, Feb 26, 2016 at 10:38 PM, Stephan Beyer wrote: >> Hi Christian, >> >> On 02/26/2016 07:53 AM, Christian Couder wrote: +test_expect_success 'bisect algorithm works in linear history with an odd number of commits' ' + git bis

Re: [PATCH 02/16] bisect: add test for the bisect algorithm

2016-02-27 Thread Christian Couder
Hi Stephan, On Fri, Feb 26, 2016 at 10:38 PM, Stephan Beyer wrote: > Hi Christian, > > On 02/26/2016 07:53 AM, Christian Couder wrote: >>> +test_expect_success 'bisect algorithm works in linear history with an odd >>> number of commits' ' >>> + git bisect start A7 && >>> + git bisect

Re: [PATCH 02/16] bisect: add test for the bisect algorithm

2016-02-26 Thread Stephan Beyer
Hi Christian, On 02/26/2016 07:53 AM, Christian Couder wrote: >> +test_expect_success 'bisect algorithm works in linear history with an odd >> number of commits' ' >> + git bisect start A7 && >> + git bisect next && >> + test "$(git rev-parse HEAD)" = "$(git rev-parse A3)" \ >>

Re: [PATCH 02/16] bisect: add test for the bisect algorithm

2016-02-25 Thread Christian Couder
On Fri, Feb 26, 2016 at 3:04 AM, Stephan Beyer wrote: > Signed-off-by: Stephan Beyer > --- > > To be honest: the test could be better, it could be more "targeted", > i.e. the example commit history could be smaller and just consider > all the cases and corner cases and whatever. > However, I made

[PATCH 02/16] bisect: add test for the bisect algorithm

2016-02-25 Thread Stephan Beyer
Signed-off-by: Stephan Beyer --- To be honest: the test could be better, it could be more "targeted", i.e. the example commit history could be smaller and just consider all the cases and corner cases and whatever. However, I made it first to understand the algorithm and verify the description of