Re: [PATCH 02/15] t5510: prepare test refs more straightforwardly

2013-10-24 Thread Junio C Hamano
Michael Haggerty writes: >> As long as you have checked that our local 'master' should be at the >> same commit as the origin's 'master' at this point, I think this >> change is OK. > > It doesn't matter what the reference points at; the only point of these > tests is to check whether branches th

Re: [PATCH 02/15] t5510: prepare test refs more straightforwardly

2013-10-23 Thread Michael Haggerty
On 10/23/2013 08:36 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> "git fetch" was being used with contrived refspecs to create tags and >> remote-tracking branches in test repositories in preparation for the >> actual tests. This is obscure and also makes one wonder whether this >> i

Re: [PATCH 02/15] t5510: prepare test refs more straightforwardly

2013-10-23 Thread Junio C Hamano
Michael Haggerty writes: > "git fetch" was being used with contrived refspecs to create tags and > remote-tracking branches in test repositories in preparation for the > actual tests. This is obscure and also makes one wonder whether this > is indeed just preparation or whether some side-effect

[PATCH 02/15] t5510: prepare test refs more straightforwardly

2013-10-23 Thread Michael Haggerty
"git fetch" was being used with contrived refspecs to create tags and remote-tracking branches in test repositories in preparation for the actual tests. This is obscure and also makes one wonder whether this is indeed just preparation or whether some side-effect of "git fetch" is being tested. So