Re: [PATCH 02/14] submodules: Add the lib-submodule-update.sh test library

2014-06-17 Thread Junio C Hamano
Jens Lehmann writes: > Oh, I forgot to add a smiley there, I haven't been serious about > that statement. I don't care too deeply about it but feel a bit > more confident with the two explicit tests. Do you want me to > change them to a single "test -e"? I have no strong preference. -- To unsubs

Re: [PATCH 02/14] submodules: Add the lib-submodule-update.sh test library

2014-06-17 Thread Jens Lehmann
Am 17.06.2014 20:44, schrieb Junio C Hamano: > Jens Lehmann writes: > >> Am 17.06.2014 00:49, schrieb Junio C Hamano: >>> Jens Lehmann writes: + GIT_WORK_TREE=. git config --unset core.worktree >>> >>> Hmph. What does GIT_WORK_TREE=. alone without GIT_DIR= >>> do? It's not like i

Re: [PATCH 02/14] submodules: Add the lib-submodule-update.sh test library

2014-06-17 Thread Junio C Hamano
Jens Lehmann writes: > Am 17.06.2014 00:49, schrieb Junio C Hamano: >> Jens Lehmann writes: >>> + git checkout -b "add_sub1" && >>> + git submodule add ./. sub1 && >> >> This is not technically wrong per-se, but having the project's >> history itself as its own submodule *is

Re: [PATCH 02/14] submodules: Add the lib-submodule-update.sh test library

2014-06-17 Thread Jens Lehmann
Am 17.06.2014 00:49, schrieb Junio C Hamano: > Jens Lehmann writes: > >> Add this test library to simplify covering all combinations of submodule >> update scenarios without having to add those to a test of each work tree >> manipulating command over and over again. >> >> The functions test_submo

Re: [PATCH 02/14] submodules: Add the lib-submodule-update.sh test library

2014-06-16 Thread Junio C Hamano
Jens Lehmann writes: > Add this test library to simplify covering all combinations of submodule > update scenarios without having to add those to a test of each work tree > manipulating command over and over again. > > The functions test_submodule_switch() and test_submodule_forced_switch() > are

[PATCH 02/14] submodules: Add the lib-submodule-update.sh test library

2014-06-15 Thread Jens Lehmann
Add this test library to simplify covering all combinations of submodule update scenarios without having to add those to a test of each work tree manipulating command over and over again. The functions test_submodule_switch() and test_submodule_forced_switch() are intended to be called from a test