Re: [PATCH 02/11] t8001/t8002: blame: demonstrate -L bounds checking bug

2013-08-05 Thread Junio C Hamano
Eric Sunshine writes: >> The problem exists with and without the incomplete line. The comment >> mentioning "incomplete line" and "wc" was inserted to explain why it >> was necessary to add one to the result of wc, which might not >> otherwise be obvious. > > Would the comment be clearer if phras

Re: [PATCH 02/11] t8001/t8002: blame: demonstrate -L bounds checking bug

2013-08-05 Thread Eric Sunshine
On Mon, Aug 5, 2013 at 3:35 PM, Eric Sunshine wrote: > On Mon, Aug 5, 2013 at 3:29 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >> >>> A bounds checking bug allows the X in -LX to extend one line past the >>> end of file. For example, given a file with 5 lines, -L6 is accepted as >>> valid

Re: [PATCH 02/11] t8001/t8002: blame: demonstrate -L bounds checking bug

2013-08-05 Thread Eric Sunshine
On Mon, Aug 5, 2013 at 3:29 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> A bounds checking bug allows the X in -LX to extend one line past the >> end of file. For example, given a file with 5 lines, -L6 is accepted as >> valid. Demonstrate this problem. >> >> While here, also add tests

Re: [PATCH 02/11] t8001/t8002: blame: demonstrate -L bounds checking bug

2013-08-05 Thread Junio C Hamano
Eric Sunshine writes: > A bounds checking bug allows the X in -LX to extend one line past the > end of file. For example, given a file with 5 lines, -L6 is accepted as > valid. Demonstrate this problem. > > While here, also add tests to check that the remaining cases of X and Y > in -LX,Y are han

[PATCH 02/11] t8001/t8002: blame: demonstrate -L bounds checking bug

2013-07-31 Thread Eric Sunshine
A bounds checking bug allows the X in -LX to extend one line past the end of file. For example, given a file with 5 lines, -L6 is accepted as valid. Demonstrate this problem. While here, also add tests to check that the remaining cases of X and Y in -LX,Y are handled correctly at and in the vicini