Re: [PATCH 02/10] t5812: add 'test_i18ngrep's missing filename parameter

2018-02-07 Thread Jeff King
On Wed, Feb 07, 2018 at 02:53:17PM +0100, SZEDER Gábor wrote: > > The "too old" curl is older than 7.19.4, which we actually fail to build > > with since v2.12.0. So they probably did not even get as far as the > > tests. ;) > > Oh, OK, I was not aware of that. The oldest non-maintenance release

Re: [PATCH 02/10] t5812: add 'test_i18ngrep's missing filename parameter

2018-02-07 Thread SZEDER Gábor
On Fri, Jan 26, 2018 at 7:27 PM, Jeff King wrote: > On Fri, Jan 26, 2018 at 01:37:00PM +0100, SZEDER Gábor wrote: > >> The second 'test_i18ngrep' invocation in the test 'curl redirects >> respect whitelist' is missing its filename parameter. This has >> remained unnoticed since its introduction i

Re: [PATCH 02/10] t5812: add 'test_i18ngrep's missing filename parameter

2018-01-30 Thread Simon Ruderich
On Fri, Jan 26, 2018 at 01:37:00PM +0100, SZEDER Gábor wrote: > [snip] > > diff --git a/t/t5812-proto-disable-http.sh b/t/t5812-proto-disable-http.sh > index d911afd24..226a4920c 100755 > --- a/t/t5812-proto-disable-http.sh > +++ b/t/t5812-proto-disable-http.sh > @@ -21,8 +21,7 @@ test_expect_succe

Re: [PATCH 02/10] t5812: add 'test_i18ngrep's missing filename parameter

2018-01-26 Thread Jeff King
On Fri, Jan 26, 2018 at 01:37:00PM +0100, SZEDER Gábor wrote: > The second 'test_i18ngrep' invocation in the test 'curl redirects > respect whitelist' is missing its filename parameter. This has > remained unnoticed since its introduction in f4113cac0 (http: limit > redirection to protocol-whitel

[PATCH 02/10] t5812: add 'test_i18ngrep's missing filename parameter

2018-01-26 Thread SZEDER Gábor
The second 'test_i18ngrep' invocation in the test 'curl redirects respect whitelist' is missing its filename parameter. This has remained unnoticed since its introduction in f4113cac0 (http: limit redirection to protocol-whitelist, 2015-09-22), because it would only cause the test to fail if Git w