Re: [PATCH 01/39] pack: make packed_git_mru global a value instead of a pointer

2017-09-06 Thread Junio C Hamano
Jeff King writes: > As an aside, the mru code could probably be simplified a bit by reusing > the list implementation from list.h (both were added around the same > time, and it wasn't worth creating a dependency then, but I think list.h > is useful and here to stay at this point). > > It's defin

Re: [PATCH 01/39] pack: make packed_git_mru global a value instead of a pointer

2017-08-30 Thread Jeff King
On Tue, Aug 29, 2017 at 11:48:27PM -0700, Jonathan Nieder wrote: > The MRU cache that keeps track of recently used packs is represented > using two global variables: > > struct mru packed_git_mru_storage; > struct mru *packed_git_mru = &packed_git_mru_storage; > > Callers never assig

[PATCH 01/39] pack: make packed_git_mru global a value instead of a pointer

2017-08-29 Thread Jonathan Nieder
The MRU cache that keeps track of recently used packs is represented using two global variables: struct mru packed_git_mru_storage; struct mru *packed_git_mru = &packed_git_mru_storage; Callers never assign to the packed_git_mru pointer, though, so we can simplify by eliminating i