SZEDER Gábor writes:
> These new tests, however, are primarily interested in the inner
> workings of __git_complete_index_file() in the presence of escapes
> and/or quotes in the path to be completed and/or in the output of 'git
> ls-files'. For these kind of tests we could simply invoke
> __git
On Wed, Apr 18, 2018 at 3:22 AM, Junio C Hamano wrote:
> SZEDER Gábor writes:
>>> Do we want to test a more common case of a filename that is two
>>> words with SP in between, i.e.
>>>
>>> $ >'hello world' && git add hel
>>>
>>> or is it known to work just fine without quoting/escaping (b
On Wed, Apr 18, 2018 at 2:31 PM, Johannes Schindelin
wrote:
> I suspect that the culprit is once again Cygwin's trick where illegal
> characters are mapped into a private Unicode page. Cygwin (and therefore
> MSYS2 runtime, and therefore the Bash used to run the test script) can use
> those filen
Hi Gábor,
On Tue, 17 Apr 2018, SZEDER Gábor wrote:
> Completion functions see all words on the command line verbatim,
> including any backslash-escapes, single and double quotes that might
> be there. Furthermore, git commands quote pathnames if they contain
> certain special characters. All th
SZEDER Gábor writes:
>>> +test_expect_failure 'complete files - quoted characters on cmdline' '
>>> + test_when_finished "rm -r \"New(Dir\"" &&
>>
>> This does not use -rf unlike the previous one?
>
> Noted.
>
> The lack of '-f' is leftover from early versions of these tests, when I
> had a h
On Wed, Apr 18, 2018 at 1:32 AM, SZEDER Gábor wrote:
> On Tue, Apr 17, 2018 at 5:48 AM, Junio C Hamano wrote:
>> SZEDER Gábor writes:
>>
>>> Do any more new tests need FUNNYNAMES* prereq?
>>
>> Hmph, all of these look like they involve some funnynames ;-)
>
> Well, I can' create a directory
On Tue, Apr 17, 2018 at 5:48 AM, Junio C Hamano wrote:
> SZEDER Gábor writes:
>
>> Do any more new tests need FUNNYNAMES* prereq?
>
> Hmph, all of these look like they involve some funnynames ;-)
Well, I can' create a directory with a '|' in its name on FAT32 (on
Linux), so this needs FUNNYN
SZEDER Gábor writes:
> Do any more new tests need FUNNYNAMES* prereq?
Hmph, all of these look like they involve some funnynames ;-)
> +test_expect_failure 'complete files - escaped characters on cmdline' '
> + test_when_finished "rm -rf \"New|Dir\"" &&
> + mkdir "New|Dir" &&
> +
Completion functions see all words on the command line verbatim,
including any backslash-escapes, single and double quotes that might
be there. Furthermore, git commands quote pathnames if they contain
certain special characters. All these create various issues when
doing git-aware path completio
9 matches
Mail list logo
