Re: [PATCH 00/11] git worktree (re)move

2016-11-16 Thread Junio C Hamano
Junio C Hamano writes: > Duy Nguyen writes: > >> The following patch should fix it if that's the same thing you saw. I >> could pile it on worktree-move series, or you can make it a separate >> one-patch series. What's your preference? > > Giving a stable output to the users is probably a good p

Re: [PATCH 00/11] git worktree (re)move

2016-11-16 Thread Junio C Hamano
Duy Nguyen writes: > The following patch should fix it if that's the same thing you saw. I > could pile it on worktree-move series, or you can make it a separate > one-patch series. What's your preference? Giving a stable output to the users is probably a good preparatory fix to what is already

Re: [PATCH 00/11] git worktree (re)move

2016-11-16 Thread Duy Nguyen
On Wed, Nov 16, 2016 at 8:05 PM, Duy Nguyen wrote: > diff --git a/worktree.c b/worktree.c > index f7869f8..fe92d6f 100644 > --- a/worktree.c > +++ b/worktree.c > @@ -173,6 +173,13 @@ static void mark_current_worktree(struct worktree > **worktrees) > free(git_dir); > } > > +static int com

Re: [PATCH 00/11] git worktree (re)move

2016-11-16 Thread Duy Nguyen
On Sat, Nov 12, 2016 at 06:53:44PM -0800, Junio C Hamano wrote: > not ok 12 - move worktree > # > # git worktree move source destination && > # test_path_is_missing source && > # git worktree list --porcelain | grep "^worktree" >actual && > # cat

[PATCH 00/11] git worktree (re)move

2016-11-11 Thread Nguyễn Thái Ngọc Duy
This is mostly a resend from last time [1]. The main difference is patch 10/11 to prevent moving a worktree that contains submodules because these .git files may need rewritten to point to the right place. I'm leaving the rewriting .git files for future (preferably done by "submodules guys"). [1]