Re: [PATCH 00/11] completion: general cleanups

2013-04-27 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 27/04/2013 21:15, Felipe Contreras ha scritto: > [...] >>> @@ -480,7 +481,7 @@ __git_complete_revlist_file () >>> # The exception is --committable, which finds the files appropriate commit. >>> __git_complete_index_file () >>> { >>> - local

Re: [PATCH 00/11] completion: general cleanups

2013-04-27 Thread Felipe Contreras
On Sat, Apr 27, 2013 at 2:15 PM, Felipe Contreras wrote: > On Sat, Apr 27, 2013 at 10:40 AM, Manlio Perillo > wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Il 27/04/2013 15:07, Felipe Contreras ha scritto: >>> [...] >>> This should do the trick. No? >>> >>> --- a/contrib/comple

Re: [PATCH 00/11] completion: general cleanups

2013-04-27 Thread Felipe Contreras
On Sat, Apr 27, 2013 at 10:40 AM, Manlio Perillo wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 27/04/2013 15:07, Felipe Contreras ha scritto: >> [...] >> This should do the trick. No? >> >> --- a/contrib/completion/git-completion.bash >> +++ b/contrib/completion/git-completion.ba

Re: [PATCH 00/11] completion: general cleanups

2013-04-27 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 27/04/2013 15:07, Felipe Contreras ha scritto: > [...] > This should do the trick. No? > > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -262,16 +262,17 @@ __git_ls_files_helper () > #If provi

Re: [PATCH 00/11] completion: general cleanups

2013-04-27 Thread Felipe Contreras
On Sat, Apr 27, 2013 at 7:36 AM, Felipe Contreras wrote: > On Sat, Apr 27, 2013 at 6:33 AM, Manlio Perillo > wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Il 27/04/2013 12:19, Felipe Contreras ha scritto: >>> Hi, >>> >>> Basically while trying to understand the code for path co

Re: [PATCH 00/11] completion: general cleanups

2013-04-27 Thread Felipe Contreras
On Sat, Apr 27, 2013 at 6:33 AM, Manlio Perillo wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 27/04/2013 12:19, Felipe Contreras ha scritto: >> Hi, >> >> Basically while trying to understand the code for path completion, I found >> that >> a lot of code was duplicated, and for n

Re: [PATCH 00/11] completion: general cleanups

2013-04-27 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 27/04/2013 12:19, Felipe Contreras ha scritto: > Hi, > > Basically while trying to understand the code for path completion, I found > that > a lot of code was duplicated, and for not much gain. > > I also noticed that doing 'git add file' doesn't

[PATCH 00/11] completion: general cleanups

2013-04-27 Thread Felipe Contreras
Hi, Basically while trying to understand the code for path completion, I found that a lot of code was duplicated, and for not much gain. I also noticed that doing 'git add file' doesn't add the trailing space as before. It's not clear if it should be possible to do that with -o filenames, but aft