Re: [PATCH 0/9] completion: avoid hard coding config var list

2018-05-10 Thread Duy Nguyen
On Fri, May 11, 2018 at 8:00 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> While at there, this config list is also available to the user via >> `git help --config` if you can't remember the exact config name you >> want and don't want to go through that big git-config man page.

Re: [PATCH 0/9] completion: avoid hard coding config var list

2018-05-10 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > While at there, this config list is also available to the user via > `git help --config` if you can't remember the exact config name you > want and don't want to go through that big git-config man page. Makes a reader anticipate a new user of levenshtein code, per

Re: [PATCH 0/9] completion: avoid hard coding config var list

2018-05-10 Thread Duy Nguyen
On Thu, May 10, 2018 at 4:19 PM, Nguyễn Thái Ngọc Duy wrote: > (on top of nd/command-list) Oh.. and it does make use of C99 designated initializer feature. I could go with out it, but since git-clean has used it for some time without anybody complaining, I figure I should take advantage of it. --

[PATCH 0/9] completion: avoid hard coding config var list

2018-05-10 Thread Nguyễn Thái Ngọc Duy
This is part of the attempt to automate more in git-completion.bash. This series is about making 'git' binary provide the list of recognized configuration variables and feeding it to git-completion.bash. The approach is less than ideal. Unlike parse-options, we don't have a reliable source for con