On Sat, Jun 13, 2015 at 10:45:29AM +0200, Michael Haggerty wrote:
> In the same email where I made those design suggestions, I also I
> pointed out a bug in the implementation of parse_oid_hex(). Maybe that
> is the reason for the test failures.
It probably is, although I either botched a conversi
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/13/2015 12:27 AM, brian m. carlson wrote:
> On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote:
>> "brian m. carlson" writes:
>>
>>> While I did run the tests between each commit, I hadn't noticed
>>> they were failing because I don
On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote:
> "brian m. carlson" writes:
>
> > While I did run the tests between each commit, I hadn't noticed they
> > were failing because I don't have Apache installed on my laptop, so they
> > were silently skipped. I'll resubmit with that
"brian m. carlson" writes:
> While I did run the tests between each commit, I hadn't noticed they
> were failing because I don't have Apache installed on my laptop, so they
> were silently skipped. I'll resubmit with that fixed.
It is somewhat strange that _only_ http part had failures like thi
On Thu, Jun 11, 2015 at 01:00:04PM -0700, Junio C Hamano wrote:
> Fetched that branch, built and found out that it does not pass the
> tests, at least these (there may be others I do not usually run that
> are broken by this series; I dunno), so I'll discard what I fetched
> for now X-<.
>
> Test
Junio C Hamano writes:
> "brian m. carlson" writes:
>
>> On Wed, Jun 10, 2015 at 11:51:14PM +, brian m. carlson wrote:
>>> On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote:
>>> > "brian m. carlson" writes:
>>> > > Convert struct object to object_id
>>> >
>>> > It seems that
On Wed, Jun 10, 2015 at 05:21:33PM -0700, Junio C Hamano wrote:
> "brian m. carlson" writes:
> > [0] https://github.com/bk2204/git.git object-id-part2
>
> No approach other than just letting reviewers fetch from there and
> taking a look is reasonable, I would think.
>
> Did you create this manu
"brian m. carlson" writes:
> On Wed, Jun 10, 2015 at 11:51:14PM +, brian m. carlson wrote:
>> On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote:
>> > "brian m. carlson" writes:
>> > > Convert struct object to object_id
>> >
>> > It seems that the last one didn't make it...
>>
On Wed, Jun 10, 2015 at 11:51:14PM +, brian m. carlson wrote:
> On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote:
> > "brian m. carlson" writes:
> > > Convert struct object to object_id
> >
> > It seems that the last one didn't make it...
>
> It appears the mail was too large
On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote:
> "brian m. carlson" writes:
> > Convert struct object to object_id
>
> It seems that the last one didn't make it...
It appears the mail was too large for vger. Unfortunately for
bisectability reasons, it is necessarily large. I
"brian m. carlson" writes:
> The final piece in this series is the conversion of struct object to use
> struct object_id. This is a necessarily large patch because of the
> large number of places this code is used.
>
> brian m. carlson (8):
> refs: convert some internal functions to use object
This is another series of conversions to struct object_id.
This series converts more of the refs code and struct object to use
struct object_id. It introduces two additional helper functions. One
is has_object_file, which is the equivalent of has_sha1_file. The name
was chosen to be slightly mo
12 matches
Mail list logo
