Re: [PATCH 0/8] Resend of GIT_TEST_PROTOCOL_VERSION patches

2019-02-07 Thread Ævar Arnfjörð Bjarmason
On Thu, Feb 07 2019, Jeff King wrote: > On Wed, Feb 06, 2019 at 11:20:32PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> >> So far we've had the convention that these GIT_TEST_* variables, >> >> e.g. the one for the commit graph, work the same way. Thus we guarantee >> >> that we get (in theory) 10

Re: [PATCH 0/8] Resend of GIT_TEST_PROTOCOL_VERSION patches

2019-02-06 Thread Jeff King
On Wed, Feb 06, 2019 at 11:20:32PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> So far we've had the convention that these GIT_TEST_* variables, > >> e.g. the one for the commit graph, work the same way. Thus we guarantee > >> that we get (in theory) 100% coverage even when running the tests in > >>

Re: [PATCH 0/8] Resend of GIT_TEST_PROTOCOL_VERSION patches

2019-02-06 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 06 2019, Jeff King wrote: > On Wed, Feb 06, 2019 at 10:52:15PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> > I wonder if it would be more obvious what's going on if we instead had a >> > prereq like: >> > >> > test_expect_success !PROTO_V2 'ls-remote --symref' ' >> > ... >> >

Re: [PATCH 0/8] Resend of GIT_TEST_PROTOCOL_VERSION patches

2019-02-06 Thread Jeff King
On Wed, Feb 06, 2019 at 10:52:15PM +0100, Ævar Arnfjörð Bjarmason wrote: > > I wonder if it would be more obvious what's going on if we instead had a > > prereq like: > > > > test_expect_success !PROTO_V2 'ls-remote --symref' ' > > ... > > ' > > > > and just skipped those tests entirely (

Re: [PATCH 0/8] Resend of GIT_TEST_PROTOCOL_VERSION patches

2019-02-06 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 06 2019, Jeff King wrote: > On Tue, Feb 05, 2019 at 04:21:14PM -0800, Jonathan Tan wrote: > >> This is on the latest master (8feddda32c ("Fifth batch for 2.21", >> 2019-02-05)) + js/protocol-advertise-multi. >> >> This is a resend of [1], which was built on the result of merging many

Re: [PATCH 0/8] Resend of GIT_TEST_PROTOCOL_VERSION patches

2019-02-06 Thread Jeff King
On Tue, Feb 05, 2019 at 04:21:14PM -0800, Jonathan Tan wrote: > This is on the latest master (8feddda32c ("Fifth batch for 2.21", > 2019-02-05)) + js/protocol-advertise-multi. > > This is a resend of [1], which was built on the result of merging many > branches. Now that most of the branches have

[PATCH 0/8] Resend of GIT_TEST_PROTOCOL_VERSION patches

2019-02-05 Thread Jonathan Tan
This is on the latest master (8feddda32c ("Fifth batch for 2.21", 2019-02-05)) + js/protocol-advertise-multi. This is a resend of [1], which was built on the result of merging many branches. Now that most of the branches have been merged to master, I have rebased it on master. The only branch that