Re: [PATCH 0/6] modernize t1500

2016-05-16 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, May 10, 2016 at 2:26 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >>> Junio C Hamano writes: >>> Subject: [PATCH 7/6] t1500: finish preparation upfront >>> >>> The earlier tests do not attempt to modify the contents of .git (by >>> creating objects or ref

Re: [PATCH 0/6] modernize t1500

2016-05-16 Thread Eric Sunshine
On Tue, May 10, 2016 at 2:26 PM, Junio C Hamano wrote: > Junio C Hamano writes: >> Junio C Hamano writes: >> Subject: [PATCH 7/6] t1500: finish preparation upfront >> >> The earlier tests do not attempt to modify the contents of .git (by >> creating objects or refs, for example), which means tha

Re: [PATCH 0/6] modernize t1500

2016-05-10 Thread Junio C Hamano
Eric Sunshine writes: > t1500: test_rev_parse: facilitate future test enhancements > t1500: reduce dependence upon global state > t1500: avoid changing working directory outside of tests > t1500: avoid setting configuration options outside of tests > t1500: avoid setting environment var

Re: [PATCH 0/6] modernize t1500

2016-05-10 Thread Junio C Hamano
Junio C Hamano writes: > Junio C Hamano writes: > >> Eric Sunshine writes: >> >>> This series modernizes t1500; it takes an entirely different approach >>> than [1][2] and is intended to replace that series. >> >> Turns out that it wasn't so painful after all. >> >> The only small niggle I have

Re: [PATCH 0/6] modernize t1500

2016-05-10 Thread Junio C Hamano
Junio C Hamano writes: > Eric Sunshine writes: > >> This series modernizes t1500; it takes an entirely different approach >> than [1][2] and is intended to replace that series. > > Turns out that it wasn't so painful after all. > > The only small niggle I have is on 6/6; my preference would be,

Re: [PATCH 0/6] modernize t1500

2016-05-09 Thread Junio C Hamano
Eric Sunshine writes: > This series modernizes t1500; it takes an entirely different approach > than [1][2] and is intended to replace that series. Turns out that it wasn't so painful after all. The only small niggle I have is on 6/6; my preference would be, because once we set up .git we do no

[PATCH 0/6] modernize t1500

2016-05-09 Thread Eric Sunshine
This series modernizes t1500; it takes an entirely different approach than [1][2] and is intended to replace that series. Whereas [1][2] dropped the systematic function-driven testing of git-rev-parse in favor of dozens of nearly identical copy/paste tests, this series retains the structure of the