On Thu, Nov 2, 2017 at 1:01 AM, Jeff King wrote:
> On Thu, Nov 02, 2017 at 04:48:45PM +0900, Junio C Hamano wrote:
>
>> Jeff King writes:
>>
>> > If the clutter is too much, it could also go into a git-notes ref
>> > (that's not already implemented, but it seems like it would be pretty
>> > easy
On Thu, Nov 02, 2017 at 04:48:45PM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > If the clutter is too much, it could also go into a git-notes ref
> > (that's not already implemented, but it seems like it would be pretty
> > easy to teach "git am" to do that).
>
> FWIW, that is what I
Jeff King writes:
> If the clutter is too much, it could also go into a git-notes ref
> (that's not already implemented, but it seems like it would be pretty
> easy to teach "git am" to do that).
FWIW, that is what I use a notes ref "amlog" for.
On Wed, Nov 01, 2017 at 03:31:42PM -0700, Stefan Beller wrote:
> On Wed, Nov 1, 2017 at 9:42 AM, Stefan Beller wrote:
>
> >> So it may make more sense just to cross-reference those merges with the
> >> topics that spawned them on the mailing list. I.e., instead of copying
> >> the cover letter c
On Wed, Nov 1, 2017 at 9:42 AM, Stefan Beller wrote:
>> So it may make more sense just to cross-reference those merges with the
>> topics that spawned them on the mailing list. I.e., instead of copying
>> the cover letter contents, just record the message-id (and update it
>> whenever a new itera
On Wed, Nov 1, 2017 at 12:14 AM, Jeff King wrote:
> On Mon, Oct 30, 2017 at 11:29:37AM -0700, Stefan Beller wrote:
>
>> > I can live with fancily-formatted cover letters. BUT. I would say if
>> > your cover letter is getting quite long, you might consider whether some
>> > of its content ought to
On Mon, Oct 30, 2017 at 11:29:37AM -0700, Stefan Beller wrote:
> > I can live with fancily-formatted cover letters. BUT. I would say if
> > your cover letter is getting quite long, you might consider whether some
> > of its content ought to be going elsewhere (either into commit messages
> > thems
On Mon, Oct 30, 2017 at 11:08 AM, Jeff King wrote:
> On Mon, Oct 23, 2017 at 01:26:41PM +0100, Philip Oakley wrote:
>
>> > Totally offtopic, but is it only me who finds these "section
>> > headers" in cover letters from some people irritating and/or
>> > jarring?
>>
>> Personally I find that, for
On Mon, Oct 23, 2017 at 01:26:41PM +0100, Philip Oakley wrote:
> > Totally offtopic, but is it only me who finds these "section
> > headers" in cover letters from some people irritating and/or
> > jarring?
>
> Personally I find that, for significant patch series, that clearly breaking
> out these
Hi Christian & Junio,
On Mon, 30 Oct 2017, Christian Couder wrote:
> On Mon, Oct 30, 2017 at 1:38 AM, Junio C Hamano wrote:
> > I've queued this from Dscho; please take it into consideration when
> > you reroll.
>
> Yeah, I was planning to add something like that, though in Dscho's
> first emai
Hi,
On Mon, Oct 30, 2017 at 1:38 AM, Junio C Hamano wrote:
> I've queued this from Dscho; please take it into consideration when
> you reroll.
Yeah, I was planning to add something like that, though in Dscho's
first email the patch was adding:
+modules += Git/Packet
and now it's adding:
> +mo
I've queued this from Dscho; please take it into consideration when
you reroll.
Thanks.
-- >8 --
From: Johannes Schindelin
Date: Sun, 29 Oct 2017 16:17:06 +0100
Subject: [PATCH] fixup! Git/Packet.pm: extract parts of t0021/rot13-filter.pl
for reuse
The patch introducing Git/Packet.pm forgot th
Hi Bryan,
On Thu, 26 Oct 2017, Bryan Turner wrote:
> On Thu, Oct 26, 2017 at 2:07 AM, Jacob Keller wrote:
> > On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote:
> >> Johannes Schindelin writes:
> >>
> >>> Note that the correct blib path starts with `C:\BuildAgent\_work` and
> >>> the line
Hi Junio,
On Thu, 26 Oct 2017, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > Note that the correct blib path starts with `C:\BuildAgent\_work` and
> > the line
> >
> > use lib (split(/:/, $ENV{GITPERLLIB}));
> >
> > splits off the drive letter from the rest of the path. Obviousl
On Thu, Oct 26, 2017 at 2:07 AM, Jacob Keller wrote:
> On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote:
>> Johannes Schindelin writes:
>>
>>> Note that the correct blib path starts with `C:\BuildAgent\_work` and
>>> the line
>>>
>>> use lib (split(/:/, $ENV{GITPERLLIB}));
>>>
>>> sp
On Thu, Oct 26, 2017 at 2:07 AM, Jacob Keller wrote:
> On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote:
>> Johannes Schindelin writes:
>>
>>> Note that the correct blib path starts with `C:\BuildAgent\_work` and
>>> the line
>>>
>>> use lib (split(/:/, $ENV{GITPERLLIB}));
>>>
>>> sp
On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
>> Note that the correct blib path starts with `C:\BuildAgent\_work` and
>> the line
>>
>> use lib (split(/:/, $ENV{GITPERLLIB}));
>>
>> splits off the drive letter from the rest of the path. Obviously,
Johannes Schindelin writes:
> Note that the correct blib path starts with `C:\BuildAgent\_work` and
> the line
>
> use lib (split(/:/, $ENV{GITPERLLIB}));
>
> splits off the drive letter from the rest of the path. Obviously, this
> fails to Do The Right Thing, and simply points to Yet Anoth
Hi Christian,
On Thu, 19 Oct 2017, Christian Couder wrote:
> Add Git/Packet.pm from parts of t0021/rot13-filter.pl
>
> perl/Git/Packet.pm | 118
>
This change, together with forcing t0021/rot13-filter.pl to use
Git/Packet.pm, breaks the t
Hi Junio,
From: "Junio C Hamano"
Christian Couder writes:
Goal
Totally offtopic, but is it only me who finds these "section
headers" in cover letters from some people irritating and/or
jarring?
Personally I find that, for significant patch series, that clearly breaking
out these di
Christian Couder writes:
> Goal
>
Totally offtopic, but is it only me who finds these "section
headers" in cover letters from some people irritating and/or
jarring? It perhaps is because I view the cover letter more as a
part of conversation, not a presentation. And when you walk up to
so
Goal
Packet related functions in Perl can be useful to write new filters or
to debug or test existing filters. So instead of having them in
t0021/rot13-filter.pl, let's extract them into a new Git/Packet.pm
module.
Links
~
This patch series has been extracted from previous "Add initial
22 matches
Mail list logo