Re: [PATCH 0/5] test-lib: filesystem prerequisites

2012-07-30 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 27.07.2012 19:29: > Michael J Gruber writes: > >> 5/5 needs a fix in the subject line, sorry. It should be: >> >> t3910: use the UTF8_NFD_TO_NFC test prereq >> >> (5/5 hasn't hit next) > > That is because I thought that you would like the lazy-probe and > that

Re: [PATCH 0/5] test-lib: filesystem prerequisites

2012-07-27 Thread Junio C Hamano
Michael J Gruber writes: > 5/5 needs a fix in the subject line, sorry. It should be: > > t3910: use the UTF8_NFD_TO_NFC test prereq > > (5/5 hasn't hit next) That is because I thought that you would like the lazy-probe and that you would be capable of rerolling it on your own ;-) -- To unsubscri

Re: [PATCH 0/5] test-lib: filesystem prerequisites

2012-07-27 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 26.07.2012 22:10: > Jeff King writes: > >> That looks like a maintenance annoyance. Can't we just have the >> prerequisite-checker lazily perform the test on demand and cache the >> result? It should be OK as long as: >> >> 1. The prereq is careful about its

Re: [PATCH 0/5] test-lib: filesystem prerequisites

2012-07-26 Thread Junio C Hamano
Jeff King writes: > That looks like a maintenance annoyance. Can't we just have the > prerequisite-checker lazily perform the test on demand and cache the > result? It should be OK as long as: > > 1. The prereq is careful about its pre- and post- conditions. We > already make sure to clea

Re: [PATCH 0/5] test-lib: filesystem prerequisites

2012-07-26 Thread Jeff King
On Thu, Jul 26, 2012 at 11:16:45AM -0700, Junio C Hamano wrote: > Consolidating the logic to set necessary prerequisites used in > various scripts is very good, but I am not sure adding them to > test-lib and run them unconditionally is a good idea. SYMLINKS is > used by 47 among 595 tests, which

Re: [PATCH 0/5] test-lib: filesystem prerequisites

2012-07-26 Thread Junio C Hamano
Michael J Gruber writes: > This mini series provides and makes use of test prerequisites for > case insensitivity, symlinks and unicode conversion. > > SYMLINKS existed before but was not used in t0050. > CASE_INSENSITIVE_FS was defined in t0003 rather than test-lib (and redone in > t0050). > UTF

[PATCH 0/5] test-lib: filesystem prerequisites

2012-07-26 Thread Michael J Gruber
This mini series provides and makes use of test prerequisites for case insensitivity, symlinks and unicode conversion. SYMLINKS existed before but was not used in t0050. CASE_INSENSITIVE_FS was defined in t0003 rather than test-lib (and redone in t0050). UTF8_NFD_TO_NFC did not exist but was redon