Re: [PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-25 Thread Junio C Hamano
Jeff King writes: > Stefan's patch is just in pu at this point, right? I do not think there > is any rushing/release concern. It is too late for either to be in > v2.4.0, so the only decision is whether to aim for "master" or "maint". > To me, they both seem to be in the same ballpark as far as r

Re: [PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Junio C Hamano
Michael Haggerty writes: > In ref_transaction_commit(), close the reference lockfiles immediately > to avoid keeping too many file descriptors open at a time. This is > pretty easy, because in the first loop (where we create the locks) we > already know what, if anything, has to be written into t

Re: [PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Stefan Beller
On Fri, Apr 24, 2015 at 10:26 AM, Jeff King wrote: > On Fri, Apr 24, 2015 at 01:35:44PM +0200, Michael Haggerty wrote: > >> In ref_transaction_commit(), close the reference lockfiles immediately >> to avoid keeping too many file descriptors open at a time. This is >> pretty easy, because in the fi

Re: [PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Jeff King
On Fri, Apr 24, 2015 at 01:35:44PM +0200, Michael Haggerty wrote: > In ref_transaction_commit(), close the reference lockfiles immediately > to avoid keeping too many file descriptors open at a time. This is > pretty easy, because in the first loop (where we create the locks) we > already know wha

[PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Michael Haggerty
In ref_transaction_commit(), close the reference lockfiles immediately to avoid keeping too many file descriptors open at a time. This is pretty easy, because in the first loop (where we create the locks) we already know what, if anything, has to be written into the lockfile. So write it and close