Re: [PATCH 0/4] attribute regression fix for maint-1.8.1 and upward

2013-03-26 Thread Duy Nguyen
On Wed, Mar 27, 2013 at 10:57 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> How about this? git_check_attr() now takes dtype as an argument >> and the caller must not add the trailing slash. This could be >> split into two patches, one for git_check_attr prototype change, >> and the other

Re: [PATCH 0/4] attribute regression fix for maint-1.8.1 and upward

2013-03-26 Thread Junio C Hamano
Duy Nguyen writes: > How about this? git_check_attr() now takes dtype as an argument > and the caller must not add the trailing slash. This could be > split into two patches, one for git_check_attr prototype change, > and the other the real meat. "git check-attr" fundamentally cannot know, but

Re: [PATCH 0/4] attribute regression fix for maint-1.8.1 and upward

2013-03-26 Thread Duy Nguyen
qOn Tue, Mar 26, 2013 at 11:39:27AM -0700, Junio C Hamano wrote: > So here is an attempt to fix the unintended regression, on top of > 9db9eecfe5c2 (attr: avoid calling find_basename() twice per path, > 2013-01-16). It consists of four patches. Not that I disagree with this. Just wanted to see ho

[PATCH 0/4] attribute regression fix for maint-1.8.1 and upward

2013-03-26 Thread Junio C Hamano
So here is an attempt to fix the unintended regression, on top of 9db9eecfe5c2 (attr: avoid calling find_basename() twice per path, 2013-01-16). It consists of four patches. The first patch is not essential to the fix, but I think it clarifies what is going on in this codepath. The second patch