Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-21 Thread Michał Górny
On Wed, 2018-12-19 at 00:59 -0500, John Passaro wrote: > On Fri, Dec 14, 2018 at 6:10 PM John Passaro wrote: > > All seems to work fine when I treat %Gs as a detached signature. > > In light of this, my best guess as to why the cleartext PGP message > didn't verify properly is that the commit data

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-18 Thread John Passaro
On Fri, Dec 14, 2018 at 6:10 PM John Passaro wrote: > All seems to work fine when I treat %Gs as a detached signature. In light of this, my best guess as to why the cleartext PGP message didn't verify properly is that the commit data normally doesn't end with \n, but as far as I can tell there's n

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-17 Thread Jeff King
On Fri, Dec 14, 2018 at 11:07:03AM -0500, John Passaro wrote: > Then I might rename the other new placeholders too: > > %Gs: signed commit signature (blank when unsigned) > %Gp: signed commit payload (i.e. in practice minus the gpgsig header; > also blank when unsigned as well) One complication:

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-14 Thread Junio C Hamano
Michał Górny writes: > Just a suggestion: since the raw signature is not very useful without > the commit data to check it against, and the commit data is non-trivial > to construct (requires mangling raw data anyway), maybe you could either > add another placeholder to get the data for signature

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-14 Thread John Passaro
On Fri, Dec 14, 2018 at 6:10 PM John Passaro wrote: > > On Fri, Dec 14, 2018 at 11:49 AM Michał Górny wrote: > > > > On Fri, 2018-12-14 at 11:07 -0500, John Passaro wrote: > > > On Thu, Dec 13, 2018 at 11:12 PM Michał Górny wrote: > > > > > > > > On Thu, 2018-12-13 at 16:22 -0500, John Passaro w

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-14 Thread John Passaro
On Fri, Dec 14, 2018 at 11:49 AM Michał Górny wrote: > > On Fri, 2018-12-14 at 11:07 -0500, John Passaro wrote: > > On Thu, Dec 13, 2018 at 11:12 PM Michał Górny wrote: > > > > > > On Thu, 2018-12-13 at 16:22 -0500, John Passaro wrote: > > > > Currently, users who do not have GPG installed have n

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-14 Thread Michał Górny
On Fri, 2018-12-14 at 11:07 -0500, John Passaro wrote: > On Thu, Dec 13, 2018 at 11:12 PM Michał Górny wrote: > > > > On Thu, 2018-12-13 at 16:22 -0500, John Passaro wrote: > > > Currently, users who do not have GPG installed have no way to discern > > > signed from unsigned commits without exami

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-14 Thread John Passaro
On Thu, Dec 13, 2018 at 11:12 PM Michał Górny wrote: > > On Thu, 2018-12-13 at 16:22 -0500, John Passaro wrote: > > Currently, users who do not have GPG installed have no way to discern > > signed from unsigned commits without examining raw commit data. I > > propose two new pretty-print placehold

Re: [PATCH 0/4] Expose gpgsig in pretty-print

2018-12-13 Thread Michał Górny
On Thu, 2018-12-13 at 16:22 -0500, John Passaro wrote: > Currently, users who do not have GPG installed have no way to discern > signed from unsigned commits without examining raw commit data. I > propose two new pretty-print placeholders to expose this information: > > %GR: full ("R"aw) contents

[PATCH 0/4] Expose gpgsig in pretty-print

2018-12-13 Thread John Passaro
Currently, users who do not have GPG installed have no way to discern signed from unsigned commits without examining raw commit data. I propose two new pretty-print placeholders to expose this information: %GR: full ("R"aw) contents of gpgsig header %G+: Y/N if the commit has nonempty gpgsig heade