Re: [PATCH 0/3] t0000 cleanups

2014-01-02 Thread Jeff King
On Thu, Jan 02, 2014 at 02:28:33PM -0800, Jonathan Nieder wrote: > > This is not exactly true. The TEST_OUTPUT_DIRECTORY setting does not > > leak. t sets $TEST_DIRECTORY (which it must, so the sub-scripts can > > find test-lib.sh and friends), and then TEST_OUTPUT_DIRECTORY uses that > > as a

Re: [PATCH 0/3] t0000 cleanups

2014-01-02 Thread Junio C Hamano
Jonathan Nieder writes: > Jeff King wrote: >> On Mon, Dec 30, 2013 at 10:51:25AM -0800, Jonathan Nieder wrote: > >>> These scratch areas for sub-tests should be under the t >>> trash directory, but because the TEST_OUTPUT_DIRECTORY >>> setting from the toplevel test leaks > [...]

Re: [PATCH 0/3] t0000 cleanups

2014-01-02 Thread Jonathan Nieder
Jeff King wrote: > On Mon, Dec 30, 2013 at 10:51:25AM -0800, Jonathan Nieder wrote: >> These scratch areas for sub-tests should be under the t >> trash directory, but because the TEST_OUTPUT_DIRECTORY >> setting from the toplevel test leaks [...] > This is not exactly true. The

Re: [PATCH 0/3] t0000 cleanups

2013-12-31 Thread Jeff King
On Mon, Dec 30, 2013 at 10:51:25AM -0800, Jonathan Nieder wrote: > I think it can be better, since the commit message left me scratching > my head while the patch itself seems pretty simple. How about > something like the following? I am fine with that format, though... > Analysis and fix: > >

Re: [PATCH 0/3] t0000 cleanups

2013-12-30 Thread Junio C Hamano
Jonathan Nieder writes: > Does that make sense? Sure, sounds good to me. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] t0000 cleanups

2013-12-30 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >> Jeff King wrote: >>> When I want to debug a failing test, I often end up doing: >>> >>> cd t >>> ./t4107- -v -i >>> cd tra >>> >>> The test names are long, so tab-completing on the trash directory is >>> very helpful. Lately I've noticed th

Re: [PATCH 0/3] t0000 cleanups

2013-12-30 Thread Junio C Hamano
Jonathan Nieder writes: > Jeff King wrote: > >> When I want to debug a failing test, I often end up doing: >> >> cd t >> ./t4107- -v -i >> cd tra >> >> The test names are long, so tab-completing on the trash directory is >> very helpful. Lately I've noticed that there are a bunch of crufty

Re: [PATCH 0/3] t0000 cleanups

2013-12-28 Thread Jonathan Nieder
Jeff King wrote: > When I want to debug a failing test, I often end up doing: > > cd t > ./t4107- -v -i > cd tra > > The test names are long, so tab-completing on the trash directory is > very helpful. Lately I've noticed that there are a bunch of crufty trash > directories in my t/ director

[PATCH 0/3] t0000 cleanups

2013-12-28 Thread Jeff King
When I want to debug a failing test, I often end up doing: cd t ./t4107- -v -i cd tra The test names are long, so tab-completing on the trash directory is very helpful. Lately I've noticed that there are a bunch of crufty trash directories in my t/ directory, which makes my tab-completion m