Re: [PATCH 0/3] interpret-trailers + commit -v bugfix

2017-05-13 Thread Brian Malehorn
> As I said, I'm a little iffy on doing this unconditionally, but it may > be the least-bad solution. I'd just worry about collateral damage to > somebody who doesn't use commit.verbose, but has something scissors-like > in their commit message. > > If you were to switch out is_scissors_line() fo

Re: [PATCH 0/3] interpret-trailers + commit -v bugfix

2017-05-12 Thread Jeff King
On Thu, May 11, 2017 at 10:03:44PM -0700, Brian Malehorn wrote: > This patch series addresses a bug in interpret-trailers. If the commit > that is being editted is "verbose", it will contain a scissors string > ("-- >8 --") and a diff. interpret-trailers doesn't interpret the > scissors and theref

[PATCH 0/3] interpret-trailers + commit -v bugfix

2017-05-11 Thread Brian Malehorn
Hi all, This patch series addresses a bug in interpret-trailers. If the commit that is being editted is "verbose", it will contain a scissors string ("-- >8 --") and a diff. interpret-trailers doesn't interpret the scissors and therefore places trailer information after the diff. A simple reprodu