Re: [PATCH 0/3] Some fixes and improvements

2018-12-12 Thread Junio C Hamano
Jonathan Tan writes: > Thanks, Aevar for looking into this. I haven't looked into detail, but: > ... > If you agree with the general direction I'm going in, when you send out > another version, I would add patch 2 somewhere near the beginning of the > set, and then squash both patch 1 and patch 3

[PATCH 0/3] Some fixes and improvements

2018-12-11 Thread Jonathan Tan
Thanks, Aevar for looking into this. I haven't looked into detail, but: - s/where/var/ in your patch 1 - I think that variables should be unset with env --unset instead of sane_unset, because (as far as I can tell) the effects of sane_unset "leak" from test block to test block. - On my co