Re: [PATCH 0/3] Re: [PATCH] unpack-tree.c: remove dead code

2014-08-12 Thread Stefan Beller
On 13.08.2014 01:57, Jonathan Nieder wrote: > Stefan Beller wrote: > >> In line 1763 of unpack-tree.c we have a condition on the current tree > [...] > > The description is describing why the patch is *correct* (i.e., not > going to introduce a bug), while what the reader wants to know is why > t

[PATCH 0/3] Re: [PATCH] unpack-tree.c: remove dead code

2014-08-12 Thread Jonathan Nieder
Stefan Beller wrote: > In line 1763 of unpack-tree.c we have a condition on the current tree [...] The description is describing why the patch is *correct* (i.e., not going to introduce a bug), while what the reader wants to know is why the change is *desirable*. Is this about making the code mo