Re: [PATCH 0/3] Minor fixes on 'git worktree'

2016-11-28 Thread Junio C Hamano
Duy Nguyen writes: > An interesting thing maybe worth > sharing is, if HEAD is broken (the only reason we would fail to create > "struct worktree" for main worktree), then "git worktree list" from > main worktree would fail too, because repo setup code fails to parse > HEAD as well and die(). Ye

Re: [PATCH 0/3] Minor fixes on 'git worktree'

2016-11-25 Thread Duy Nguyen
On Fri, Nov 25, 2016 at 7:24 PM, Duy Nguyen wrote: > Adding the test for the failed parse_ref() is possible, I think. But > since that function is destined to die, as I promised to use > refs-provided api instead of rolling out a custom ref parser, and I'm > going to have another hard look at refs

Re: [PATCH 0/3] Minor fixes on 'git worktree'

2016-11-25 Thread Duy Nguyen
On Wed, Nov 23, 2016 at 11:52 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This fixes two things: >> >> - make sure the first item is always the main worktree even if we >>fail to retrieve some info >> >> - keep 'worktree list' order stable (which in turn fixes the random

Re: [PATCH 0/3] Minor fixes on 'git worktree'

2016-11-23 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This fixes two things: > > - make sure the first item is always the main worktree even if we >fail to retrieve some info > > - keep 'worktree list' order stable (which in turn fixes the random >failure on my 'worktree-move' series > Nguyễn Thái Ngọc Duy (

[PATCH 0/3] Minor fixes on 'git worktree'

2016-11-22 Thread Nguyễn Thái Ngọc Duy
This fixes two things: - make sure the first item is always the main worktree even if we fail to retrieve some info - keep 'worktree list' order stable (which in turn fixes the random failure on my 'worktree-move' series Nguyễn Thái Ngọc Duy (3): worktree.c: zero new 'struct worktree'