Re: [PATCH 0/2] color-moved: ignore all space changes by default

2017-10-26 Thread Stefan Beller
On Thu, Oct 26, 2017 at 1:42 AM, Jacob Keller wrote: >> >> Hello, >> >> I'm not sure if this is a good default. I think it's not obvious >> that moved code gets treated differently than regular changes. I >> wouldn't expect git diff to ignore whitespace changes (without me >> telling it to) and s

Re: [PATCH 0/2] color-moved: ignore all space changes by default

2017-10-26 Thread Jacob Keller
On Thu, Oct 26, 2017 at 12:22 AM, Simon Ruderich wrote: > On Wed, Oct 25, 2017 at 03:46:18PM -0700, Stefan Beller wrote: >> On Mon, Oct 23, 2017 at 7:52 PM, Stefan Beller wrote[1]: >>> On Mon, Oct 23, 2017 at 6:54 PM, Junio C Hamano wrote: * As moved-lines display is mostly a presentati

Re: [PATCH 0/2] color-moved: ignore all space changes by default

2017-10-26 Thread Simon Ruderich
On Wed, Oct 25, 2017 at 03:46:18PM -0700, Stefan Beller wrote: > On Mon, Oct 23, 2017 at 7:52 PM, Stefan Beller wrote[1]: >> On Mon, Oct 23, 2017 at 6:54 PM, Junio C Hamano wrote: >>> >>> * As moved-lines display is mostly a presentation thing, I wonder >>>if it makes sense to always match loo

[PATCH 0/2] color-moved: ignore all space changes by default

2017-10-25 Thread Stefan Beller
On Mon, Oct 23, 2017 at 7:52 PM, Stefan Beller wrote[1]: > On Mon, Oct 23, 2017 at 6:54 PM, Junio C Hamano wrote: >> >> * As moved-lines display is mostly a presentation thing, I wonder >>if it makes sense to always match loosely wrt whitespace >>differences. > > Well, sometimes the use