Re: [PATCH 0/2] Test improvements for 'sg/complete-paths'

2018-05-21 Thread Johannes Schindelin
Hi Junio, On Mon, 21 May 2018, Johannes Schindelin wrote: > On Fri, 18 May 2018, SZEDER Gábor wrote: > > > > > So, I think for v2 I will rewrite these tests to call > > > > __git_complete_index_file() directly instead of using > > > > 'test_completion', and will include a test with spaces in pat

Re: [PATCH 0/2] Test improvements for 'sg/complete-paths'

2018-05-21 Thread Johannes Schindelin
Hi Gábor, On Fri, 18 May 2018, SZEDER Gábor wrote: > > > So, I think for v2 I will rewrite these tests to call > > > __git_complete_index_file() directly instead of using > > > 'test_completion', and will include a test with spaces in path > > > names. > > > > Quite well thought-out reasoning.

[PATCH 0/2] Test improvements for 'sg/complete-paths'

2018-05-18 Thread SZEDER Gábor
> > So, I think for v2 I will rewrite these tests to call > > __git_complete_index_file() directly instead of using > > 'test_completion', and will include a test with spaces in path names. > > Quite well thought-out reasoning. Thanks. Unfortunately I couldn't get around to it soon enough, and n