Re: [PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Johannes Sixt
Am 2/25/2013 21:31, schrieb Jeff King: > Subject: [PATCH] utf8: accept alternate spellings of UTF-8 > ... > JSixt, can you double-check that this passes t4210 for you? Yes, t4210 and all other *i18n* and *log* tests pass with this patch. Thanks, -- Hannes > > utf8.c | 20 ++-- >

Re: [PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Torsten Bögershausen
On 25.02.13 16:19, Jeff King wrote: > On Mon, Feb 25, 2013 at 09:37:50AM +0100, Johannes Sixt wrote: > >> From: Johannes Sixt >> >> iconv on Windows does not know the encoding name "utf8", and does not >> re-encode log messages when this name is given. Request "UTF-8" encoding. >> >> Signed-off-b

Re: [PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Jeff King
On Mon, Feb 25, 2013 at 07:54:47PM +0100, Torsten Bögershausen wrote: > (beside that I couldn't find t4210 somewhere), It's newly added in 04deccd. > diff --git a/utf8.c b/utf8.c > index a4ee665..e9850d0 100644 > --- a/utf8.c > +++ b/utf8.c > @@ -487,6 +487,10 @@ char *reencode_string(const char

Re: [PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Jeff King
On Mon, Feb 25, 2013 at 11:06:37AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > ... I think the simplest thing would just be: > > > > diff --git a/utf8.c b/utf8.c > > index 1087870..8d42b50 100644 > > --- a/utf8.c > > +++ b/utf8.c > > @@ -507,6 +507,17 @@ char *reencode_string(const ch

Re: [PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Junio C Hamano
Jeff King writes: > ... I think the simplest thing would just be: > > diff --git a/utf8.c b/utf8.c > index 1087870..8d42b50 100644 > --- a/utf8.c > +++ b/utf8.c > @@ -507,6 +507,17 @@ char *reencode_string(const char *in, const char > *out_encoding, const char *in_e > > if (!in_encoding)

Re: [PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Torsten Bögershausen
On 25.02.13 09:37, Johannes Sixt wrote: > From: Johannes Sixt > > iconv on Windows does not know the encoding name "utf8", and does not > re-encode log messages when this name is given. Request "UTF-8" encoding. > > Signed-off-by: Johannes Sixt > --- > I'm not sure whether I'm right to say tha

Re: [PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Jeff King
On Mon, Feb 25, 2013 at 09:37:50AM +0100, Johannes Sixt wrote: > From: Johannes Sixt > > iconv on Windows does not know the encoding name "utf8", and does not > re-encode log messages when this name is given. Request "UTF-8" encoding. > > Signed-off-by: Johannes Sixt > --- > I'm not sure whet

[PATCH ] t4210-log-i18n: spell encoding name "UTF-8" correctly

2013-02-25 Thread Johannes Sixt
From: Johannes Sixt iconv on Windows does not know the encoding name "utf8", and does not re-encode log messages when this name is given. Request "UTF-8" encoding. Signed-off-by: Johannes Sixt --- I'm not sure whether I'm right to say that "UTF-8" is the correct spelling. Anyway, 'iconv -l' o