Re: [PATCH +warn] Implement https public key pinning

2016-02-22 Thread Christoph Egger
Hi! Junio C Hamano writes: > Christoph Egger writes: > >> Add the http.pinnedpubkey configuration option for public key >> pinning. It allows any string supported by libcurl -- >> base64(sha256(pubkey)) or filename of the full public key. >> >> If cURL does not support pinning (is too old) outpu

Re: [PATCH +warn] Implement https public key pinning

2016-02-17 Thread Junio C Hamano
Christoph Egger writes: > Add the http.pinnedpubkey configuration option for public key > pinning. It allows any string supported by libcurl -- > base64(sha256(pubkey)) or filename of the full public key. > > If cURL does not support pinning (is too old) output a warning to the > user. > > Signed

Re: [PATCH +warn] Implement https public key pinning

2016-02-16 Thread Junio C Hamano
Jeff King writes: > On Mon, Feb 15, 2016 at 07:19:07PM -0800, Junio C Hamano wrote: > >> I suspect that "#else" is too agressive to bail out or something >> silly like that. >> >> Oh, I think I found it. >> >> @@ -216,6 +219,13 @@ static int http_options(const char *var, const char >> *value,

Re: [PATCH +warn] Implement https public key pinning

2016-02-15 Thread Jeff King
On Mon, Feb 15, 2016 at 07:19:07PM -0800, Junio C Hamano wrote: > I suspect that "#else" is too agressive to bail out or something > silly like that. > > Oh, I think I found it. > > @@ -216,6 +219,13 @@ static int http_options(const char *var, const char > *value, void *cb) > if (!strcmp(

Re: [PATCH +warn] Implement https public key pinning

2016-02-15 Thread Junio C Hamano
Jeff King writes: > On Mon, Feb 15, 2016 at 03:25:32PM -0800, Junio C Hamano wrote: > >> Thanks. This, when applied on top of 2.7.1, however seems to break >> at least t5541 and t5551. > > Hrm. I cannot see how the new code can possibly do anything unless > http.pinnedpubkey is set, and our test

Re: [PATCH +warn] Implement https public key pinning

2016-02-15 Thread Jeff King
On Mon, Feb 15, 2016 at 03:25:32PM -0800, Junio C Hamano wrote: > Thanks. This, when applied on top of 2.7.1, however seems to break > at least t5541 and t5551. Hrm. I cannot see how the new code can possibly do anything unless http.pinnedpubkey is set, and our tests don't do that. Neither t5541

Re: [PATCH +warn] Implement https public key pinning

2016-02-15 Thread Junio C Hamano
Thanks. This, when applied on top of 2.7.1, however seems to break at least t5541 and t5551. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH +warn] Implement https public key pinning

2016-02-15 Thread Christoph Egger
Add the http.pinnedpubkey configuration option for public key pinning. It allows any string supported by libcurl -- base64(sha256(pubkey)) or filename of the full public key. If cURL does not support pinning (is too old) output a warning to the user. Signed-off-by: Christoph Egger --- This ver