Re: [PATCH] worktree: stop supporting moving worktrees manually

2015-12-30 Thread Eric Sunshine
On Tue, Dec 29, 2015 at 8:55 AM, Duy Nguyen wrote: > On Mon, Dec 28, 2015 at 1:22 PM, Eric Sunshine > wrote: >> On Sun, Dec 27, 2015 at 10:43:16AM +0700, Nguyễn Thái Ngọc Duy wrote: >>> If you move a linked working tree to another file system, or >>> -within a file system that does not support

Re: [PATCH] worktree: stop supporting moving worktrees manually

2015-12-29 Thread Duy Nguyen
On Mon, Dec 28, 2015 at 1:22 PM, Eric Sunshine wrote: > On Sun, Dec 27, 2015 at 10:43:16AM +0700, Nguyễn Thái Ngọc Duy wrote: >> The current update_linked_gitdir() has a bug that can create "gitdir" >> file in non-multi-worktree setup. Instead of fixing this, we step back a >> bit. The original de

Re: [PATCH] worktree: stop supporting moving worktrees manually

2015-12-27 Thread Eric Sunshine
On Sun, Dec 27, 2015 at 10:43:16AM +0700, Nguyễn Thái Ngọc Duy wrote: > The current update_linked_gitdir() has a bug that can create "gitdir" > file in non-multi-worktree setup. Instead of fixing this, we step back a > bit. The original design was probably not well thought out. For now, if > the us

[PATCH] worktree: stop supporting moving worktrees manually

2015-12-26 Thread Nguyễn Thái Ngọc Duy
The current update_linked_gitdir() has a bug that can create "gitdir" file in non-multi-worktree setup. Instead of fixing this, we step back a bit. The original design was probably not well thought out. For now, if the user manually moves a worktree, they have to fix up "gitdir" file manually or th