Re: [PATCH] versionsort: support reorder prerelease suffixes

2015-03-10 Thread Eric Sunshine
On Tue, Mar 10, 2015 at 3:52 AM, Junio C Hamano wrote: > Duy Nguyen writes: >> How about.. >> >> ".. "1.0-rc1" will appear before "1.0". This key can be specified >> multiple times, one for each suffix. The order of suffixes in the Minor bike-shedding: s/one for each suffix/once per suffix/ >>

Re: [PATCH] versionsort: support reorder prerelease suffixes

2015-03-10 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Mar 5, 2015 at 8:28 AM, Junio C Hamano wrote: >> Junio C Hamano writes: >> +versionsort.prereleaseSuffix:: +When version sort is used in linkgit:git-tag[1], prerelease +tags (e.g. "1.0-rc1") may appear after the main release +"1.0". B

Re: [PATCH] versionsort: support reorder prerelease suffixes

2015-03-08 Thread Duy Nguyen
On Thu, Mar 5, 2015 at 8:28 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> +versionsort.prereleaseSuffix:: >>> +When version sort is used in linkgit:git-tag[1], prerelease >>> +tags (e.g. "1.0-rc1") may appear after the main release >>> +"1.0". By specifying the suffix "-rc"

Re: [PATCH] versionsort: support reorder prerelease suffixes

2015-03-04 Thread Junio C Hamano
Junio C Hamano writes: >> +versionsort.prereleaseSuffix:: >> +When version sort is used in linkgit:git-tag[1], prerelease >> +tags (e.g. "1.0-rc1") may appear after the main release >> +"1.0". By specifying the suffix "-rc" in this variable, >> +"1.0-rc1" will appear before "1.0".

Re: [PATCH] versionsort: support reorder prerelease suffixes

2015-02-27 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Second round. Looking better. We can do > "1.0-pre12 < 1.0-rc0 < 1.0 < 1.0-post1" too but it relies on > config key's loading order, a bit iffy. > > Documentation/config.txt | 7 +++ > t/t7004-tag.sh |

[PATCH] versionsort: support reorder prerelease suffixes

2015-02-26 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Second round. Looking better. We can do "1.0-pre12 < 1.0-rc0 < 1.0 < 1.0-post1" too but it relies on config key's loading order, a bit iffy. Documentation/config.txt | 7 +++ t/t7004-tag.sh | 28 +++ versioncmp.c