Re: [PATCH] use refnames instead of "left"/"right" in dirdiffs

2013-03-28 Thread John Keeping
On Thu, Mar 28, 2013 at 02:19:44PM +, John Keeping wrote: > On Thu, Mar 28, 2013 at 01:46:16PM +0100, Christoph Anton Mitterer wrote: > > On Wed, 2013-03-27 at 23:07 +, John Keeping wrote: > > > That's not going to work well on Windows, is it? > > > > Uhm Winwhat? No seriously... doesn't d

Re: [PATCH] use refnames instead of "left"/"right" in dirdiffs

2013-03-28 Thread John Keeping
On Thu, Mar 28, 2013 at 01:46:16PM +0100, Christoph Anton Mitterer wrote: > On Wed, 2013-03-27 at 23:07 +, John Keeping wrote: > > That's not going to work well on Windows, is it? > > Uhm Winwhat? No seriously... doesn't dir-diff fail ther anway? The mkdir > right now also uses mkpath with "/"

Re: [PATCH] use refnames instead of "left"/"right" in dirdiffs

2013-03-28 Thread Christoph Anton Mitterer
Hi John. On Wed, 2013-03-27 at 23:07 +, John Keeping wrote: > That's not going to work well on Windows, is it? Uhm Winwhat? No seriously... doesn't dir-diff fail ther anway? The mkdir right now also uses mkpath with "/"... and I could read in it's documentation that it would automatically tr

Re: [PATCH] use refnames instead of "left"/"right" in dirdiffs

2013-03-27 Thread John Keeping
On Wed, Mar 27, 2013 at 11:13:17PM +0100, Christoph Anton Mitterer wrote: > Currently, when a dir-diff is made with git-difftool the two revisions are > stored in two temporary directories ".../left" and ".../right". > Many difftools show these pathnames in ther UI and therefore it would be > help

[PATCH] use refnames instead of "left"/"right" in dirdiffs

2013-03-27 Thread Christoph Anton Mitterer
Currently, when a dir-diff is made with git-difftool the two revisions are stored in two temporary directories ".../left" and ".../right". Many difftools show these pathnames in ther UI and therefore it would be helpful for users, if actual reference names specified as progam arguments was used ins