Re: [PATCH] use filetest pragma to work with ACL

Jeff King writes: >> Attached a cleanup proposal and moving the use at the top. > > Thanks, it looks good to me. I somehow missed this exchange; sorry for being late to pick it up.

Re: [PATCH] use filetest pragma to work with ACL

On Thu, Oct 19, 2017 at 09:53:28AM +0200, Guillaume Castagnino wrote: > > This "use" will unconditionally at compile-time (such as "compile" is > > for perl, anyway). Which raises a few questions: > > > > - would we want to use "require" instead to avoid loading when we > > don't enter this

Re: [PATCH] use filetest pragma to work with ACL

Hi, Le mercredi 18 octobre 2017 à 17:24 -0400, Jeff King a écrit : > On Wed, Oct 18, 2017 at 07:55:31PM +, Guillaume Castagnino wrote: > > > From: Guillaume Castagnino > > [...] > > Stefan raised a few meta issues, all of which I agree with. But I had > some questions about the patch itself

Re: [PATCH] use filetest pragma to work with ACL

On Wed, Oct 18, 2017 at 07:55:31PM +, Guillaume Castagnino wrote: > From: Guillaume Castagnino > [...] Stefan raised a few meta issues, all of which I agree with. But I had some questions about the patch itself: > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index 9208f42ed1753..0

Re: [PATCH] use filetest pragma to work with ACL

On Wed, Oct 18, 2017 at 12:55 PM, Guillaume Castagnino wrote: > From: Guillaume Castagnino > > as stated in comment in > https://github.com/git/git/commit/46a13857fc036b54ac2ddd0a218e5cc171aa7bd9#diff-00703a794a540acf45e225abd6aeda3b > the referenced commit is broken when using ACL and not basi

[PATCH] use filetest pragma to work with ACL

From: Guillaume Castagnino as stated in comment in https://github.com/git/git/commit/46a13857fc036b54ac2ddd0a218e5cc171aa7bd9#diff-00703a794a540acf45e225abd6aeda3b the referenced commit is broken when using ACL and not basic UNIX rights. this commit handle ACL too --- gitweb/gitweb.perl | 1 +