Re: [PATCH] update-index: fix segfault with missing --cacheinfo argument

2014-06-04 Thread Junio C Hamano
Jeff King writes: > Running "git update-index --cacheinfo" without any further > arguments results in a segfault rather than an error > message. Commit ec160ae (update-index: teach --cacheinfo a > new syntax "mode,sha1,path", 2014-03-23) added code to > examine the format of the argument, but for

[PATCH] update-index: fix segfault with missing --cacheinfo argument

2014-06-04 Thread Jeff King
Running "git update-index --cacheinfo" without any further arguments results in a segfault rather than an error message. Commit ec160ae (update-index: teach --cacheinfo a new syntax "mode,sha1,path", 2014-03-23) added code to examine the format of the argument, but forgot to handle the NULL case.