Re: [PATCH] transport submodules: correct error message

2017-01-17 Thread Stefan Beller
On Tue, Jan 17, 2017 at 4:15 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Tue, Jan 17, 2017 at 3:42 PM, Junio C Hamano wrote: >>> Stefan Beller writes: >>> Trying to push with --recurse-submodules=on-demand would run into the same problem. To fix this issue 1) sp

Re: [PATCH] transport submodules: correct error message

2017-01-17 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Jan 17, 2017 at 3:42 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> Trying to push with --recurse-submodules=on-demand would run into >>> the same problem. To fix this issue >>> 1) specifically mention that we looked for branches on the remote. >>

Re: [PATCH] transport submodules: correct error message

2017-01-17 Thread Stefan Beller
On Tue, Jan 17, 2017 at 3:42 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Trying to push with --recurse-submodules=on-demand would run into >> the same problem. To fix this issue >> 1) specifically mention that we looked for branches on the remote. > > That makes an incorrect statem

Re: [PATCH] transport submodules: correct error message

2017-01-17 Thread Junio C Hamano
Stefan Beller writes: > Trying to push with --recurse-submodules=on-demand would run into > the same problem. To fix this issue > 1) specifically mention that we looked for branches on the remote. That makes an incorrect statement ("not found on any remote"---we did not inspect all of the sa

[PATCH] transport submodules: correct error message

2017-01-13 Thread Stefan Beller
When push.recurseSubmodules is set to "check" or "on-demand", the transport layer tries to determine if a submodule needs pushing. This check is done by walking all remote refs that are known. For remotes we only store the refs/heads/* (and tags), which doesn't include all commits. In e.g. Gerrit