Re: [PATCH] tests: set temp variables using 'env' in test function instead of subshell

David Tran writes: > Fixed the broken &&-chain and the tests run correctly. The double env is > fixed to be a single env. The useless subshells are removed. > ... Hmph. > test_expect_success 'need valid notes ref' ' > - (MSG=1 GIT_NOTES_REF=/ && export MSG GIT_NOTES_REF && > - test_mu

[PATCH] tests: set temp variables using 'env' in test function instead of subshell

Originally, the code used subshells instead of FOO=BAR command because the variable would otherwise leak into the surrounding context of the POSIX shell when 'command' is a shell function. The subshell was used to hold the context for the test. Using 'env' in the test function sets the temp variabl