Re: [PATCH] tagger id

2005-07-14 Thread Eric W. Biederman
Junio C Hamano <[EMAIL PROTECTED]> writes: > Eric W. Biederman xmission.com> writes: > > >> Part of the request was to put all of this information together >> in a common place. And note that it is actually: >> tagger="$GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE" >> Where the

Re: [PATCH] tagger id

2005-07-14 Thread Eric W. Biederman
Junio C Hamano <[EMAIL PROTECTED]> writes: > I am afraid I do not follow you. I was confused. My big problem was that we don't really have an in tree user, and there wasn't a good explanation anywhere. So it was hard to track this down. I'm going to lobby for a script to import patches from

Re: [PATCH] tagger id

2005-07-12 Thread Junio C Hamano
Eric W. Biederman xmission.com> writes: > Since we are still looking at this there is one change in the user > interface I would like to make to simplify things for the end user. > The only time when GIT_COMMITTER != GIT_AUTHOR is in git_commit_script > when we you are making a new commit based o

Re: [PATCH] tagger id

2005-07-12 Thread Eric W. Biederman
Linus Torvalds <[EMAIL PROTECTED]> writes: > Eric, > I ended up coding the ident stuff a bit differently, and I didn't do done > the tag/git-id part yet. Can you check out my latest commit (pushed out, > but it will probably take a few minutes to mirror out), and do the final > tag stuff based

Re: [PATCH] tagger id

2005-07-12 Thread Junio C Hamano
Eric W. Biederman xmission.com> writes: > > Junio C Hamano cox.net> writes: > > > The only in-tree user after your patch is applied is the tagger > > stuff, so in that sense committer_ident may make more sense. > > There is also the commit path, and that comes from C. I'm not > quite certain

Re: [PATCH] tagger id

2005-07-12 Thread Linus Torvalds
Eric, I ended up coding the ident stuff a bit differently, and I didn't do done the tag/git-id part yet. Can you check out my latest commit (pushed out, but it will probably take a few minutes to mirror out), and do the final tag stuff based on that? Linus - To unsubscribe fr

Re: [PATCH] tagger id

2005-07-12 Thread Petr Baudis
Dear diary, on Tue, Jul 12, 2005 at 05:04:23PM CEST, I got a letter where "Eric W. Biederman" <[EMAIL PROTECTED]> told me that... > > By the way, I do not particularly like the name "git-id". There > > could be IDs for different kinds (not just people) we would want > > later (file IDs, for exampl

Re: [PATCH] tagger id

2005-07-12 Thread Eric W. Biederman
Junio C Hamano <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Eric W. Biederman) writes: > >> Should this default to git_author_ident or git_committer_ident? >> I'm not really certain how we expect to use the different flavors. > > The only in-tree user after your patch is applied is the tagger

Re: [PATCH] tagger id

2005-07-12 Thread Junio C Hamano
[EMAIL PROTECTED] (Eric W. Biederman) writes: > Should this default to git_author_ident or git_committer_ident? > I'm not really certain how we expect to use the different flavors. The only in-tree user after your patch is applied is the tagger stuff, so in that sense committer_ident may make mor

Re: [PATCH] tagger id

2005-07-11 Thread Eric W. Biederman
[EMAIL PROTECTED] (Eric W. Biederman) writes: > This patch adds a command git-id for use on > the command line to see what git will set your id too, > and for use in scripts (git-tag-script) so they can get your git id. > > The common code for computing the git-id is moved to ident.c > > Fix parse

[PATCH] tagger id

2005-07-11 Thread Eric W. Biederman
This patch adds a command git-id for use on the command line to see what git will set your id too, and for use in scripts (git-tag-script) so they can get your git id. The common code for computing the git-id is moved to ident.c Fix parse_date to not mind being passed a constant date to parse.