Re: [PATCH] t960[34]: mark cvsimport tests as requiring perl

2014-11-18 Thread Jeff King
On Tue, Nov 18, 2014 at 10:56:22AM -0800, Jonathan Nieder wrote: > Jeff King wrote: > > > It would probably make sense to have these scripts just > > skip_all if NO_PERL is set, but I opted to follow the pattern > > set by t9600, etc. If somebody feels like spending time refactoring the > > cvsim

Re: [PATCH] t960[34]: mark cvsimport tests as requiring perl

2014-11-18 Thread Jonathan Nieder
Jeff King wrote: > It would probably make sense to have these scripts just > skip_all if NO_PERL is set, but I opted to follow the pattern > set by t9600, etc. If somebody feels like spending time refactoring the > cvsimport test harness, be my guest. Wouldn't it be a matter of the following, plu

[PATCH] t960[34]: mark cvsimport tests as requiring perl

2014-11-18 Thread Jeff King
Git-cvsimport is written in perl, which understandably causes the tests to fail if you build with NO_PERL (which will avoid building cvsimport at all). The earlier cvsimport tests in t9600-t9602 are all marked with a PERL prerequisite, but these ones are not. The one in t9603 was likely not notice