Re: [PATCH] t7300-clean: demonstrate deleting nested repo with an ignored file breakage

2019-08-26 Thread SZEDER Gábor
On Sun, Aug 25, 2019 at 11:32:28PM +0100, Philip Oakley wrote: > Hi Szeder, > > On 25/08/2019 19:59, SZEDER Gábor wrote: > >'git clean -fd' must not delete an untracked directory if it belongs > s/untracked// > I don't believe it should matter either way for a sub-module > (sub-directory). I just

Re: [PATCH] t7300-clean: demonstrate deleting nested repo with an ignored file breakage

2019-08-25 Thread Philip Oakley
Hi Szeder, On 25/08/2019 19:59, SZEDER Gábor wrote: 'git clean -fd' must not delete an untracked directory if it belongs s/untracked// I don't believe it should matter either way for a sub-module (sub-directory). to a different Git repository or worktree. msybr split the assertion from the f

Re: [PATCH] t7300-clean: demonstrate deleting nested repo with an ignored file breakage

2019-08-25 Thread SZEDER Gábor
On Sun, Aug 25, 2019 at 08:59:18PM +0200, SZEDER Gábor wrote: > 'git clean -fd' must not delete an untracked directory if it belongs > to a different Git repository or worktree. Unfortunately, if a > '.gitignore' rule in the outer repository happens to match a file in a > nested repository or work

[PATCH] t7300-clean: demonstrate deleting nested repo with an ignored file breakage

2019-08-25 Thread SZEDER Gábor
'git clean -fd' must not delete an untracked directory if it belongs to a different Git repository or worktree. Unfortunately, if a '.gitignore' rule in the outer repository happens to match a file in a nested repository or worktree, then something goes awry and 'git clean -fd' does delete the con