Jeff King writes:
>> -cat >expect_cookies.txt <> +cat
> This can be spelled:
>
> sort >expect_cookies.txt <
> can't it? Then we do not even incur the extra process. :)
Yeah, true. Running cat only to feed a pipe with contents of a
single file or the here-doc is an anti-p
On Mon, Sep 17, 2018 at 02:45:55PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > Yes, I think sorting the expect file would work fine. I'm OK with that,
> > or just leaving a comment. The comment has the bonus that it does not
> > cost an extra process at runtime. I'd probably use a sor
t way
we do not have to remember the list must be sorted.
Here is what I'll merge to 'next'.
-- >8 --
From: Todd Zullinger
Date: Fri, 7 Sep 2018 19:22:05 -0400
Subject: [PATCH] t5551-http-fetch-smart.sh: sort cookies before comparing
MIME-Version: 1.0
Content-Type: text/plain; c
Todd Zullinger writes:
> With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output
> used in the 'cookies stored in http.cookiefile when http.savecookies
> set' test before comparing it to the expected cookies.
>
> ¹ https://github.com/curl/curl/commit/e2ef8d6fa ("cookies: support
>
On Fri, Sep 07, 2018 at 11:28:41PM -0400, Todd Zullinger wrote:
> > So this fix looks fine. It might be worth a comment above the creation
> > of expect_cookies.txt to mention it must be in sorted order (of course
> > anybody modifying it would see a test failure).
>
> I thought about running the
Jeff King wrote:
> On Fri, Sep 07, 2018 at 07:22:05PM -0400, Todd Zullinger wrote:
>
>> With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output
>> used in the 'cookies stored in http.cookiefile when http.savecookies
>> set' test before comparing it to the expected cookies.
>>
>> ¹
On Fri, Sep 07, 2018 at 07:22:05PM -0400, Todd Zullinger wrote:
> With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output
> used in the 'cookies stored in http.cookiefile when http.savecookies
> set' test before comparing it to the expected cookies.
>
> ¹ https://github.com/curl/c
With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output
used in the 'cookies stored in http.cookiefile when http.savecookies
set' test before comparing it to the expected cookies.
¹ https://github.com/curl/curl/commit/e2ef8d6fa ("cookies: support
creation-time attribute for cooki
8 matches
Mail list logo
