Re: [PATCH] t5318: avoid unnecessary command substitutions

2018-08-13 Thread Junio C Hamano
SZEDER Gábor writes: > - echo $(git -C repo log --pretty="%ct" -1) \ > - $(git -C repo rev-parse one) >expect && > + { > + git -C repo log --pretty=format:"%ct " -1 && > + git -C repo rev-parse one > + } >expect && Heh, "format:"%ct " to make the f

Re: [PATCH] t5318: avoid unnecessary command substitutions

2018-08-13 Thread Derrick Stolee
On 8/12/2018 8:30 PM, SZEDER Gábor wrote: Two tests added in dade47c06c (commit-graph: add repo arg to graph readers, 2018-07-11) prepare the contents of 'expect' files by 'echo'ing the results of command substitutions. That's unncessary, avoid them by directly saving the output of the commands

[PATCH] t5318: avoid unnecessary command substitutions

2018-08-12 Thread SZEDER Gábor
Two tests added in dade47c06c (commit-graph: add repo arg to graph readers, 2018-07-11) prepare the contents of 'expect' files by 'echo'ing the results of command substitutions. That's unncessary, avoid them by directly saving the output of the commands executed in those command substitutions. Si